-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated configuration '--show-source` #9814
Remove deprecated configuration '--show-source` #9814
Conversation
12d2d69
to
24e6538
Compare
|
Thanks for your contribution! We won't be able to release this until v0.3.0 so it's going to be a bit before we can merge |
Hi @zanieb, since there are more of these deprecations in the codebase, do you mind if I keep adding commits to this PR, or shall I open a separate one for each of them? |
e5a7e31
to
ed2866c
Compare
Hey @tibor-reiss — I'm unsure. Ideally these things would be in separate pull requests for our changelog and review but we're talking pretty far out here and it could be a significant amount to keep your changes up to date with Another thing we can do is have deprecated options error in preview mode first but retain a warning in stable. |
Hi @zanieb, I understand. I added the 2nd commit just before your answer - talk about timing. And as you predicted, merge conflict. |
@tibor-reiss I extracted the first breaking change into its own PR and ship it as part of 0.3. We want to wait a little longer with the other options because it isn't that long ago that we've deprecated them. |
ed2866c
to
9d99534
Compare
9d99534
to
2f5817e
Compare
Co-authored-by: Micha Reiser <micha@reiser.io> Fixes parts of #7650
Co-authored-by: Micha Reiser <micha@reiser.io> Fixes parts of #7650
Fixes parts of #7650:
Extracted from this PR
1. removes the deprecated configuration 'format'. It was deprecated in https://github.com//pull/8203 in favor of 'output-format'. Update: Was merged in https://github.com//pull/10170 Tests: - `cargo run -p ruff -- --explain RET505` works - `cargo run -p ruff -- --explain RET505 --output-format json` works - `cargo run -p ruff -- --explain RET505 --format json` does not work anymoreTests:
cargo run -p ruff -- --show-source
does not work anymorecargo run -p ruff -- --no-show-source
does not work anymoreresolves: #7349
Part of #7650